-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rtd #2195
Rtd #2195
Conversation
From my side, similar support and questions as the ones raised in ome/bio-formats-documentation#196:
|
this makes me wonder again if we shouldn't rename https://github.com/ome/openmicroscopy to match "omero-documentation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due to a limitation in sphinx not being able to build more than a subdirectory? Bit confused.
That's the name I was thinking but we can pick the name we wish
|
So you would vote for making this live and starting to publish asap?
👍 from my side for capturing this
While in the case of Bio-Formats, most of the components and the documentation are typically released in sync (which is possibly why we are unsure about decoupling the tag numbers), we have long passed this stage for the OMERO documentation. https://docs.openmicroscopy.org/omero/5.6.3/ tells Decoupling the tag from the binary does not seem to make a huge difference to me although we might need to review the internal versions. A possibility would be track the server/web version numbers and use them appropriately i.e. refer to OMERO.server 5.6.3 and OMERO.web 5.12.0
Thinking of the discussion above, it looks like the current common denominator is that this constitutes the reference documentation for the OMERO 5 ecosystem. Another possibility would be https://omero5.readthedocs.io/. Likely harder to find but it would allow e.g. to clearly separate documentation sets between OMERO 5 and a future breaking version.
Definitely feel like the last (but hardest) thing to unify. A fewnames coming to mind ome/omero, ome/omero-binaries, ome/omero-dist (all of this with their |
Re-activating this branch following the release. Migrating to rtd will simplify the release of the doc. |
In the same spirit as ome/ome-zarr-py#121, should we create a reathedocs project and activate per-PR build so that we can review this in the checks? |
I have tested on my account see https://jburel-ome-documentation.readthedocs.io/en/latest/ and restarted the build |
While I would have expected the content to be equivalent to https://docs.openmicroscopy.org/omero/5.6.4, the link above still displays OMERO 5.6.3 documentation? |
I think it is due to the settings I put a while back, when checking stable vs latest etc. |
The reason it was 5.6.3 is b/c I set at the time an environment variable in rtd (see https://readthedocs.org/dashboard/jburel-ome-documentation/environmentvariables/) to test and be compatible with the current build system. I did not change it before building. It is now at 5.6.4 |
Is the last commit deployed? |
Excluding the question around the versioning/lifecycle above which can be captured as a next to do, the staging readthedocs deployment looks good to me. Overall, the migration proposed here makes sense to me, builds on top of an established platform used by many projects (https://readthedocs.org/sustainability/) and aims to address several issues that have been arising over the last few years:
As always, these benefits come at the cost of a different workflow both in terms of review and release processes. The primary question is whether the rest of the @ome/omero team is comfortable with this approach:
|
The versions have been decoupled in this PR, the updated doc is now available. |
I have all the changes that I wanted to do for that round. |
Note that this PR does not address the hosting of documentation like https://docs.openmicroscopy.org/omero-model/5.6.5/javadoc/ |
Yes: the doc and the code have been decoupled i.e. the doc version is 5.6.5-SNAPSHOT and the server version is 5.6.4 |
Going back to this, 👍 for this initially but I could also see that becoming a landing page (like https://omero-guides.readthedocs.io/) on top of |
Thanks for the suggestion, better to use |
I don't think so. Or at least, not as guides are currently constructed. This gets back to the four types of documentation. Again, I don't think there would be a problem having a page that points to all four types, but there are definitely different user flows and I certainly would suggest right now that we should get rid of the flows we have without planning/designing. |
Maybe this raises the question of whether the documentation version should be exposed in the generated documentation or only remains internal to reduce the confusion. |
Docs look good :) |
I could see using "5.6" since that's relevant for compatibility. Moving forward, maybe just "OMERO 6", but that might be something we consider when it comes to the RTD URLs. |
And semi-related, assuming the current content gets published under e.g. https://omero.readthedocs.io/, do we believe we could easily redirect all the URLs if part of the content was split into its own reference documentation at a later stage? In general, from the thread, there are several open questions/actions that will need to be tackled post-merging of this PR including redirection from docs.openmicroscopy.org, CI, configuration etc. @jburel do you have a reference place to capture these? |
See #2198 for actions |
@will-moore 9d76168 now uses the major/minor version so that will avoid confusion |
I think so, it will be similar to the redirect we have already
See #2198 for actions |
Merging as discussed yesterday and preparing |
Following the IT problems, this PR migrates the documentation to readthedocs.
see https://jburel-ome-documentation.readthedocs.io/en/latest/
The Javadoc, slice doc migration is not considered in this PR
cc @joshmoore @sbesson