Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch ROI export CSV unicode #165

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Dec 17, 2019

Fixes #158.
This reverts commit d9119de.
Shouldn't be needed once we have sys.stdout.encoding UTF-8 on
the server.

Requires ome/omero-py#150

To test, export ROIs from an image with pixel size of microns and check that µm is written to CSV columns correctly.

This reverts commit d9119de.
Shouldn't be needed once we have sys.stdout.encoding UTF-8 on
the server.
@will-moore will-moore changed the title Revert "csv data.encode('utf-8') before writing to csv" batch ROI export CSV unicode Dec 17, 2019
@jburel
Copy link
Member

jburel commented Jan 8, 2020

script not available

@will-moore
Copy link
Member Author

Don't know why scripts are not uploaded to the server. But I just uploaded this script manually (from this branch).

@jburel
Copy link
Member

jburel commented Jan 8, 2020

area (µm) This should be area (µm²)
iviewer works correctly

also the values could be rounded e.g. 66.95859863900198 => 66.959

@will-moore
Copy link
Member Author

This PR is just rolling back the .encode() that we don't need now. Not intending to add new features.
Also, I don't know how easy it is to write superscript to a text file.
I'm not sure we should be rounding here as the output is not for display but for further analysis
(equivalent to exporting a lossy jpeg instead of tiff for analysis).

@jburel
Copy link
Member

jburel commented Jan 8, 2020

My point is that iviewer and the script generate both a CSV but one round the result one does not
that could be very confusing for user
I will create an issue for unit display

@jburel
Copy link
Member

jburel commented Jan 9, 2020

issues #168 and #169 created
Merging the PR

@jburel jburel merged commit b68b841 into ome:develop Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

py3 issues
2 participants