Array order #32
Open
Array order #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An investigation into ignoring the order of arrays #29.
I think this can be done, just not in the approach laid out in this PR. I think, for now, some feedback would be good, but in the meantime, if you do not care about array orders, I'd suggest formatting your object prior to sending to diffler to make sure arrays are associative rather than ordered (see README.md example in this PR).
I think my next step would be to look at doing this associative mapping internally, but keeping an array index of values should a difference occur.
Can install this branch with
npm i diffler@next* Side notes