Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure when a link target has an undefined parent #668

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

DianLiI
Copy link
Contributor

@DianLiI DianLiI commented Feb 3, 2025

What does this PR do?

Fixes #666

Before submitting

  • Did you read the contributing guideline?
  • [n/a] Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f786412) to head (a4226eb).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #668   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         6671      6671           
=========================================
  Hits          6671      6671           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mauvilsa mauvilsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

CHANGELOG.rst Outdated Show resolved Hide resolved
@mauvilsa mauvilsa merged commit 4b956d4 into omni-us:main Feb 4, 2025
29 checks passed
@mauvilsa mauvilsa added the bug Something isn't working label Feb 4, 2025
@DianLiI DianLiI deleted the deep-link-missing-parant branch February 4, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

link_arguments target not ignored when it is deeply nested and its parent is undefined
2 participants