Skip to content

Commit

Permalink
Merge pull request #2 from omnia-network/release/0.3.1
Browse files Browse the repository at this point in the history
release/0.3.1
  • Loading branch information
ilbertt authored Dec 4, 2023
2 parents 85f985f + 2addcf7 commit 2b46b15
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 5 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,15 @@ on:
branches:
- main
pull_request:
types:
- opened
- synchronize
- reopened
- ready_for_review

jobs:
tests:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ic-websocket-js",
"version": "0.3.0",
"version": "0.3.1",
"description": "IC WebSocket on the Internet Computer",
"license": "MIT",
"repository": {
Expand Down
4 changes: 2 additions & 2 deletions src/ic-websocket.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ import { WsAgent } from "./agent";
* The default expiration time for receiving an ack message from the canister after sending a message.
* It's **3/2 times** the canister's default send ack period.
*/
const DEFAULT_ACK_MESSAGE_TIMEOUT_MS = 90000;
const DEFAULT_ACK_MESSAGE_TIMEOUT_MS = 450_000;

/**
* Interface to create a new IcWebSocketConfig. For a simple configuration, use {@link createWsConfig}.
Expand All @@ -65,7 +65,7 @@ export interface IcWebSocketConfig<S extends _WS_CANISTER_SERVICE> {
* The expiration (in milliseconds) time for receiving an ack message from the canister after sending a message.
* If the ack message is not received within this time, the connection will be closed.
* This parameter should always me **3/2 times or more** the canister's send ack period.
* @default 90000 (90 seconds = 3/2 default send ack period on the canister)
* @default 450_000 (7.5 minutes = 3/2 default send ack period on the canister)
*/
ackMessageTimeout?: number;
/**
Expand Down

0 comments on commit 2b46b15

Please sign in to comment.