Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and update some metadata #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dblessing
Copy link

@dblessing dblessing commented Sep 7, 2016

Are you open to adding automated testing via Travis? This includes some minor changes so the project can have run on Travis. I added only Ruby versions 2.2 and 2.3 because the dependencies don't install cleanly on older versions. If there is a better matrix, please let me know.

This also removed the ruby-debug19 dependency because it's really old and I couldn't even get it installed on my workstation with Ruby 2.3.1. If there is a reason why we need it, we can see how we can include it in a way that installs easily on both dev workstations and Travis.

Finally, it adds the Gemfile.lock, because this should be committed instead of ignored.

Thanks for considering adding this to your repo. Please enable the main repo in Travis before merging this.

@dblessing
Copy link
Author

@miketierney Will you please review this PR when you have a moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant