Make repo rubocop compliant #20
Conversation
According to rubocop on default settings
|
@n8chz thanks for contribution! |
|
Solves #18 |
|
Rubocop is in Gemfile for :test and :development, per line 24. There is also already a .rubocop.yml at top level. Blanking that out (assuming that's what's meant by 'standard style guide') results in 164 offenses. Correct these? Note that default rubocop requires class documentation comments throughout. Have a style preference for those? |
|
@n8chz yes, please correct whatever is possible. You can leave only class documentation unresolved, I'll take care of them later. |
Currently 33 offenses. 3 are for overly-long blocks. Remainder are for lack of comments.
|
@n8chz rebase your branch please |
|
Is that as simple as |
|
@n8chz |
|
@n8chz or, as an alternative, you can just apply your rubocop config to a fresh branch, to avoid manual conflict resolution. |
|
Clearly I'm in over my head here. Sorry. |
|
@n8chz okay, I'll take care of it. |
Mehonoshin
force-pushed
the
master
branch
3 times, most recently
from
4d3069b to
bed5c11
Compare
According to rubocop on default settings
Does "introduce rubocop" also entail adding rubocop to Gemfile?