[ASP-5422] Add TOOL_TIMEOUT env var as config #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusktreader
requested changes
Dec 12, 2024
CHANGELOG.rst
Outdated
| @@ -6,9 +6,17 @@ This file keeps track of all notable changes to the License Manager Agent Charm. | |||
|
|
|||
| Unreleased | |||
| ---------- | |||
| * Update the charm to support installing the new License Manager Agent process [ASP-5383] | |||
| * Remove support for CentOS7 | |||
| * Include `TOOL_TIMEOUT` env var in the agent's configuratin | |||
There was a problem hiding this comment.
Please include the task-id here.
There was a problem hiding this comment.
There wasn't a task specifically for this change, but since it was found out during the work on ASP-5422, I added it to the CHANGELOG.
julianaklulo
force-pushed
the
fix/ASP-5422--add-tool-timeout
branch
from
a9f9864 to
cb26e8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add the env var
TOOL_TIMEOUTas a configuration to the charm.Why
The default value (6 seconds) is not enough for the new DSLS license server, since it takes longer to run.
Having this value as a configuration enables quick editing this value.
Task: https://jira.scania.com/browse/ASP-5422Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.