Reduce number of articles fetched per request #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense to me. @sywhb what do you think? |
|
🎉 This PR is included in version 1.9.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
aaachen
pushed a commit
to aaachen/obsidian-omnivore
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reduces the number of articles fetched in each request from the Omnivore graphql server. Currently, the number is set to 50. If fetching content is enabled, the graphql server tends to return a 500 server error and causes the plugin to fail to sync articles. This could be a larger problem with the graphql server, but to fix this issue for now, I've lowered the number of articles fetched concurrently to 15. I've tested this PR on my personal Omnivore account.
I believe this is PR resolves #185 and resolves #193. It could be related to #179 as well, but I'm not sure.
If you'd like, I'd also be happy to refactor this change out into a configuration setting (as opposed to just changing the hardcoded value). Let me know if that'd be preferred.