Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some highlighted markdown content not synced #243

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

sywhb
Copy link
Collaborator

@sywhb sywhb commented Jul 12, 2024

  • The highlightedMarkdown was not yet uploaded when downloading so we should wait until the uploading to complete
  • Increase the download timeout to 10 mins

* The highlightedMarkdown was not yet uploaded when downloading so we should wait until the uploading to complete
* Increase the download timeout to 10 mins
@sywhb sywhb requested review from jacksonh and satindar as code owners July 12, 2024 14:12
@gaborpelesz
Copy link

Hey @sywhb, I had an issue lately, do you think its relevant and this PR would solve it? (Want to gather some more info before I open a ticket)

I was reading and highlighting on an iPad without internet connection, after ~2 hours I connected the iPad to internet and I wanted to check on my phone whether Omnivore synced my recent updates. This action made all my highlights unreachable that I did over the 2 hours of no internet (very annoying for sure). I can still see the highlights in the iPad but can not open the note for them (clicking on "note" doesn't do anything). Also exporting doesn't recognize these highlights (nor the highlighted section, neither the note for it). The system also changed all of my highlight colors for the document to orange, expect for those that I can see (but not reach) in the iPad, these remain yellow. Do you have any suggestion on this issue if this PR is not the solution?

@sywhb
Copy link
Collaborator Author

sywhb commented Jul 16, 2024

Hey @sywhb, I had an issue lately, do you think its relevant and this PR would solve it? (Want to gather some more info before I open a ticket)

I was reading and highlighting on an iPad without internet connection, after ~2 hours I connected the iPad to internet and I wanted to check on my phone whether Omnivore synced my recent updates. This action made all my highlights unreachable that I did over the 2 hours of no internet (very annoying for sure). I can still see the highlights in the iPad but can not open the note for them (clicking on "note" doesn't do anything). Also exporting doesn't recognize these highlights (nor the highlighted section, neither the note for it). The system also changed all of my highlight colors for the document to orange, expect for those that I can see (but not reach) in the iPad, these remain yellow. Do you have any suggestion on this issue if this PR is not the solution?

Hey @gaborpelesz , sorry to make you lose some highlights.

I think the underlying issue of your case and this PR could be both related to some race conditions when syncing highlights across devices but this PR will only fix the issue if you are using Obsidian plugin.

Feel free to open another ticket and if possible, can you please provide your username so I can further debug in our system?

@sywhb sywhb merged commit 582b217 into master Jul 16, 2024
6 checks passed
@sywhb sywhb deleted the fix/download-content branch July 16, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants