Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More graceful shutdown for the api server #3541

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

jacksonh
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnivore-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 3:35am
omnivore-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 3:35am

Comment on lines +221 to +229
await new Promise<void>((resolve) => {
listener.close((err) => {
console.log('[api]: Express listener closed')
if (err) {
console.log('[api]: error stopping listener', { err })
}
resolve()
})
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jacksonh jacksonh merged commit 3bd99a0 into main Feb 19, 2024
6 checks passed
@jacksonh jacksonh deleted the fix/api-server-graceful-shutdown branch February 19, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants