Updates based on the UX feedback #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinlu3
reviewed
Nov 5, 2024
Comment on lines
164
to
168
| <div | ||
| className={classNames( | ||
| 'container', | ||
| styles.container, | ||
| isSticky ? styles.containerSticky : '' | ||
| isSticky ? styles.containerSticky : '', | ||
| 'container' |
There was a problem hiding this comment.
Whats the difference between the class and the component?
There was a problem hiding this comment.
Good question. Initially I removed the container, then added back the class. Let me try to revert to the component.
calvinlu3
reviewed
Nov 5, 2024
There was a problem hiding this comment.
The icon inside the circle doesn't seem to be centered. Seems to be slightly leaning left. Do you see that too?
There was a problem hiding this comment.
Oh yeah, it might relate to some changes after introducing the icon. I will look inot.
There was a problem hiding this comment.
Not sure why I can't reproduce locally.
There was a problem hiding this comment.
I was looking at the screenshots, but locally it is fine for me too.
calvinlu3
approved these changes
Nov 7, 2024
| className={classNames( | ||
| 'container', |
zhx828
force-pushed
the
minor-ux-updates
branch
from
ed3149b to
48fc33e
Compare
zhx828
force-pushed
the
minor-ux-updates
branch
from
91aca87 to
5862dc9
Compare
zhx828
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://github.com/oncokb/oncokb-pipeline/issues/601