Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure KMS support #148

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Azure KMS support #148

merged 4 commits into from
Jul 27, 2022

Conversation

mhmxs
Copy link
Contributor

@mhmxs mhmxs commented Jul 26, 2022 •
edited
Loading

Description

Fixes # (147)

Type of change

Please check options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ongoing ...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mhmxs mhmxs mentioned this pull request Jul 26, 2022
Open
@romdalf romdalf linked an issue Jul 26, 2022 that may be closed by this pull request
[RFE] Azure KeyVault Support #139
Closed
@mhmxs mhmxs force-pushed the azure-kms-support branch from 522c7bd to 3d89b81 Compare July 26, 2022 14:44
@mhmxs mhmxs marked this pull request as ready for review July 27, 2022 06:11
@mhmxs mhmxs requested a review from romdalf July 27, 2022 06:11
romdalf
romdalf approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@romdalf romdalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhmxs mhmxs merged commit ff7c7cb into v2-alpha Jul 27, 2022
@mhmxs mhmxs deleted the azure-kms-support branch July 27, 2022 08:12
@romdalf romdalf mentioned this pull request Jul 27, 2022
Merged
7 tasks
romdalf added a commit that referenced this pull request Jul 27, 2022
@romdalf @mhmxs
v2 alpha to main (#145)
e8d322a 
* Multi KMS support included AWS KMS (#112)
  * AWS KMS provider support
* Select decryption backend via Roundrobin (#117)
* Select fastet backend (#118)
* Increase debuggability (#120)
* Add unit tests (#121)
  * Kuttl based e2e test with debug provider
  * Kuttl based e2e test with debug provider - fix
  * e2e test for vault
* e2e test of AWS KMS (#124)
  * Simplify docker build
* Multi Kube version e2e and tasks polish (#125)
  * Fix e2e test github action names
  * Fix e2e test github action KUBEVER
* Delete socket file before listen and terminate if socket is missing (#127)
* e2e test with the supported versions of Kubernetes (#128)
* Split Taskfile to sections (#129)
* Generate manifests for producation usage (#130)
  * Generate manifests for producation usage
  * Multiple configuration options for Vault
  * Fix generator test
* Generate helm chart (#131)
  * Generate helm chart
  * Fix generator test
  * Fix github actions related to make
* Validate log level (#144)
  * Code scan of common codebase called library
* Update SECURITY.md
* Update README.md
* Fix typo of prod helm gen
* Azure KMS support (#148)
* Azure KMS support
* Azure KMS manifests generation
* Fix pipelines
* Typo fixes

Co-authored-by: Richard Kovacs <[email protected]>
@romdalf romdalf mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romdalf romdalf romdalf approved these changes

Assignees

@mhmxs mhmxs

Labels
None yet
Projects
None yet
Milestone
KMS Pluging Redesign - Trousseau v2
Development

Successfully merging this pull request may close these issues.

[RFE] Azure KeyVault Support
2 participants
@mhmxs @romdalf