[SYCLomatic] Enable migration of CUBLASLT_EPILOGUE_GELU & GELU_AUX #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweij1
reviewed
Oct 31, 2024
zhiweij1
reviewed
Oct 31, 2024
| cublasLtEpilogue_t e; | ||
| e = CUBLASLT_EPILOGUE_DEFAULT; | ||
| e = CUBLASLT_EPILOGUE_RELU; | ||
| e = CUBLASLT_EPILOGUE_GELU; | ||
| e = CUBLASLT_EPILOGUE_GELU_AUX; |
There was a problem hiding this comment.
GELU_AUX is not as same as GELU.
According to CUBLAS doc, GELU_AUX is
Apply GELU point-wise transform to the results (x := GELU(x)). This epilogue mode outputs GELU input as a separate matrix (useful for training). See CUBLASLT_MATMUL_DESC_EPILOGUE_AUX_POINTER of [cublasLtMatmulDescAttributes_t](https://docs.nvidia.com/cuda/cublas/index.html#cublasltmatmuldescattributes-t).
So you need update the implementation to copy the GELU input to EPILOGUE_AUX_POINTER
zhiweij1
reviewed
Oct 31, 2024
| cublasLtEpilogue_t e; | ||
| e = CUBLASLT_EPILOGUE_DEFAULT; | ||
| e = CUBLASLT_EPILOGUE_RELU; | ||
| e = CUBLASLT_EPILOGUE_GELU; |
There was a problem hiding this comment.
Please also add E2E tests for those 2 epilogues in: https://github.com/oneapi-src/SYCLomatic-test/blob/SYCLomatic/features/feature_case/cublasLt/matmul.cu
Co-authored-by: Jiang, Zhiwei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @zhiweij1 @zhimingwang36