Skip to content

Commit

Permalink
Merge pull request #2609 from kbenzie/benie/fix-large-obj-noref-arg
Browse files Browse the repository at this point in the history
Fix passing struct object by value
  • Loading branch information
kbenzie authored Jan 24, 2025
2 parents 2f5f4bb + f71ef62 commit e370a2b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion test/adapters/level_zero/event_cache_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ static std::shared_ptr<_zel_tracer_handle_t> tracer = [] {
zel_core_callbacks_t prologue_callbacks{};
prologue_callbacks.Event.pfnCreateCb = OnEnterEventCreate;
prologue_callbacks.Event.pfnDestroyCb = OnEnterEventDestroy;
return enableTracing(prologue_callbacks, {});
return enableTracing(std::move(prologue_callbacks), {});
}();

template <typename... Args> auto combineFlags(std::tuple<Args...> tuple) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ static std::shared_ptr<_zel_tracer_handle_t> tracer = [] {
zel_core_callbacks_t prologue_callbacks{};
prologue_callbacks.CommandList.pfnAppendWaitOnEventsCb =
OnAppendWaitOnEventsCb;
return enableTracing(prologue_callbacks, {});
return enableTracing(std::move(prologue_callbacks), {});
}();

using urMultiQueueMultiDeviceEventCacheTest = uur::urAllDevicesTest;
Expand Down
6 changes: 3 additions & 3 deletions test/adapters/level_zero/ze_tracer_common.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@

#include <memory>

std::shared_ptr<_zel_tracer_handle_t>
enableTracing(zel_core_callbacks_t prologueCallbacks,
zel_core_callbacks_t epilogueCallbacks) {
inline std::shared_ptr<_zel_tracer_handle_t>
enableTracing(zel_core_callbacks_t &&prologueCallbacks,
zel_core_callbacks_t &&epilogueCallbacks) {
EXPECT_EQ(zeInit(ZE_INIT_FLAG_GPU_ONLY), ZE_RESULT_SUCCESS);

zel_tracer_desc_t tracer_desc = {ZEL_STRUCTURE_TYPE_TRACER_EXP_DESC, nullptr,
Expand Down

0 comments on commit e370a2b

Please sign in to comment.