-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CUDA][HIP] Return error on silently failing urEventGetInfo queries for interop created events #1399
[CUDA][HIP] Return error on silently failing urEventGetInfo queries for interop created events #1399
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
=======================================
Coverage 12.51% 12.51%
=======================================
Files 239 239
Lines 35942 35942
Branches 4076 4076
=======================================
Hits 4498 4498
Misses 31440 31440
Partials 4 4 ☔ View full report in Codecov by Sentry. |
56ac261
to
8f28dd2
Compare
8f28dd2
to
2f8dc5b
Compare
@GeorgeWeb I am just planning implementing the suggestion here: #1491 (comment) @alexbatashev FYI |
@JackAKirk That sounds like a plan. I'll update this error on nullptr queue instead. |
c61956e
to
33e1852
Compare
@oneapi-src/unified-runtime-maintain just a ping to have a look as that's been stale for some time. Thanks! |
…terop created events
…erop created events
33e1852
to
df6e9d2
Compare
This PR addresses #1235 by returning an error on event queries, specifically
UR_EVENT_INFO_COMMAND_QUEUE
, that cannot be supported for the CUDA and HIP adapters. This is an effect of creating the ur_event from a native event which leads to not being able to fully initialize the UR object.intel/llvm CI: intel/llvm#12958