Don't use empty match test files #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
approved these changes
Sep 26, 2024
RossBrunton
force-pushed
the
ross/smartmatch
branch
from
acf3594 to
cdefe00
Compare
This patch removes any empty ".match" files, and instructs ctest to run the tests verbatim if there is no match file available. As well as providing more useful output, this also handles the case where the test startup and/or teardown causes the test runner to fail. Previously, this would be ignored (as it produced no output). I also modified cts_exe.py so that it uses the same parameters as ctest, so the same command invocation could be used for both.
RossBrunton
force-pushed
the
ross/smartmatch
branch
from
cdefe00 to
acb9ca3
Compare
martygrant
approved these changes
Sep 26, 2024
|
Merging without LLVM commit since this doesn't touch LLVM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes any empty ".match" files, and instructs ctest to
run the tests verbatim if there is no match file available.
As well as providing more useful output, this also handles the case
where the test startup and/or teardown causes the test runner to fail.
Previously, this would be ignored (as it produced no output).