Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[L0 v2] make device allocation resident and support multi-device buffers #2166

Merged
merged 6 commits into from
Oct 10, 2024
Merged

[L0 v2] make device allocation resident and support multi-device buffers #2166

merged 6 commits into from
Oct 10, 2024

Conversation

igchor
Copy link
Member

@igchor igchor commented Oct 2, 2024

No description provided.

@github-actions github-actions bot added ci/cd Continuous integration/devliery common Changes or additions to common utilities conformance Conformance test suite issues. level-zero L0 adapter specific issues labels Oct 2, 2024
pbalcer
pbalcer reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this stack of commits has become unreviewable.

test/adapters/level_zero/v2/memory_residency.cpp Outdated
// TODO: change to use
// https://spec.oneapi.io/level-zero/latest/core/api.html#ze-device-ip-version-ext-t
// when that is stable.
bool isPVC(ur_device_handle_t hDevice) {
Copy link
Contributor

@pbalcer pbalcer Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to some commons.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

source/adapters/level_zero/v2/memory.cpp Show resolved Hide resolved
@igchor
Copy link
Member Author

igchor commented Oct 3, 2024

this stack of commits has become unreviewable.

I'll rebase once #2016 is merged

@igchor igchor force-pushed the memory_migration branch 3 times, most recently from ee1bac4 to 9d44d0e Compare October 4, 2024 19:38
@igchor igchor marked this pull request as ready for review October 4, 2024 19:38
@igchor igchor requested review from a team as code owners October 4, 2024 19:38
@igchor
Copy link
Member Author

igchor commented Oct 4, 2024

this stack of commits has become unreviewable.

I'll rebase once #2016 is merged

Done.

@igchor igchor force-pushed the memory_migration branch 3 times, most recently from 1263037 to f369220 Compare October 7, 2024 22:53
pbalcer
pbalcer reviewed Oct 9, 2024
View reviewed changes
test/adapters/level_zero/v2/memory_residency.cpp Outdated Show resolved Hide resolved
source/common/umf_helpers.hpp Outdated Show resolved Hide resolved
source/adapters/level_zero/v2/usm.cpp Outdated Show resolved Hide resolved
source/common/umf_helpers.hpp Outdated Show resolved Hide resolved
source/adapters/level_zero/v2/memory.cpp Show resolved Hide resolved
@igchor
[common] fix umf2urResult
d9facf2 
In case of UMF_RESULT_ERROR_MEMORY_PROVIDER_SPECIFIC
the underlying native error was not being translated
to UR correctly (it was returned as is).

Fix this by adding native error handlers and implement one
for LEVEL_ZERO provider
@igchor igchor requested review from a team as code owners October 9, 2024 14:42
@igchor igchor requested a review from mmoadeli October 9, 2024 14:42
@igchor
[L0 v2] implement urMemGetInfo
28db1fd 
and make failures for urMemImage optional.

There is no image support on PVC, and those tests
won't be run.
@github-actions github-actions bot added cuda CUDA adapter specific issues hip HIP adapter specific issues native-cpu Native CPU adapter specific issues labels Oct 9, 2024
@pbalcer pbalcer merged commit e3910da into oneapi-src:main Oct 10, 2024
76 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbalcer pbalcer pbalcer approved these changes

@mmoadeli mmoadeli Awaiting requested review from mmoadeli mmoadeli is a code owner automatically assigned from oneapi-src/unified-runtime-hip-write

Assignees
No one assigned
Labels
ci/cd Continuous integration/devliery common Changes or additions to common utilities conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues native-cpu Native CPU adapter specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igchor @pbalcer