Improve specification of command-buffer update errors #2462
+449
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
EwanC
force-pushed
the
cmd-buf_update_errors
branch
from
664febd to
c166e74
Compare
EwanC
changed the title
EwanC
force-pushed
the
cmd-buf_update_errors
branch
from
c166e74 to
00ca890
Compare
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Dec 16, 2024
Bump UR tag to [Improve specification of command-buffer update errors](oneapi-src/unified-runtime#2462)
kbenzie
approved these changes
Dec 18, 2024
Bensuo
reviewed
Dec 19, 2024
EwanC
force-pushed
the
cmd-buf_update_errors
branch
from
00ca890 to
7d4d09c
Compare
EwanC
commented
Dec 20, 2024
The `UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP` query no longer exists, so error defined for trying to make an updatable command-buffer when a device doesn't support it needs reworded to say if no capabilities are supported. Additionally, for each individual update capability, specify that an error is thrown if update is attempted using that characteristic. UR CTS added to verify this.
Return unsupported when a device doesn't support local memory update but attempts the following usage > If pNewGlobalWorkSize is set and pNewLocalWorkSize is nullptr, then the runtime implementation will choose the local work size.
EwanC
force-pushed
the
cmd-buf_update_errors
branch
from
7d4d09c to
b341dd0
Compare
Bensuo
approved these changes
Jan 7, 2025
Co-authored-by: Ben Tracy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXPquery no longer exists, so error defined for trying to make an updatable command-buffer when a device doesn't support it needs reworded to say if no capabilities are supported.Additionally, for each individual update capability, specify that an error is thrown if update is attempted using that characteristic.
UR CTS added to verify the above clarifications.
DPC++ PR intel/llvm#16383