Use std::string in create_logger to avoid valgrind warning in some configs #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumfare
reviewed
Jan 3, 2025
aarongreig
force-pushed
the
aaron/fixValgrindWarnInLogger
branch
from
7121a60 to
42fb01f
Compare
|
LLVM PR intel/llvm#16516 |
callumfare
approved these changes
Jan 3, 2025
RossBrunton
approved these changes
Jan 6, 2025
dm-vodopyanov
pushed a commit
to intel/llvm
that referenced
this pull request
Jan 7, 2025
Batches the following bug fixes: * oneapi-src/unified-runtime#2504 * oneapi-src/unified-runtime#2517 * oneapi-src/unified-runtime#2524 --------- Signed-off-by: Neil R. Spruit <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
kbenzie
added a commit
that referenced
this pull request
Jan 7, 2025
Use std::string in create_logger to avoid valgrind warning in some configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically this should fix warnings such as the one seen in pytorch CI: https://github.com/pytorch/pytorch/actions/runs/12043736074/job/33601354052#step:14:10286