Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L0]: Fix Out Event in Enqueue Wait Events to prevent reuse #2524

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Jan 6, 2025

  • Fix Out Event created in Enqueue Wait Events to ensure the event is
    not reused.
  • Removed completion logic that was allowing caching of the event.
  • event_handle_t zeEventDestroy handles the memory leak issue that this
    branch was attempting to fix.

@nrspruit nrspruit requested a review from a team as a code owner January 6, 2025 22:22
@nrspruit nrspruit added level-zero L0 adapter specific issues v0.11.x Include in the v0.11.x release labels Jan 6, 2025
@nrspruit nrspruit marked this pull request as draft January 6, 2025 22:32
@nrspruit nrspruit marked this pull request as ready for review January 6, 2025 22:36
- Fix Out Event created in Enqueue Wait Events to ensure the event is
  not reused.
- Removed completion logic that was allowing caching of the event.
- event_handle_t zeEventDestroy handles the memory leak issue that this
  branch was attempting to fix.

Signed-off-by: Neil R. Spruit <[email protected]>
@nrspruit nrspruit force-pushed the fix_enqueue_wait_out_event branch from 0540c1d to da04d13 Compare January 6, 2025 22:41
nrspruit added a commit to nrspruit/llvm that referenced this pull request Jan 6, 2025
@nrspruit nrspruit added the ready to merge Added to PR's which are ready to merge label Jan 6, 2025
@kbenzie kbenzie merged commit 3472b5b into oneapi-src:main Jan 7, 2025
73 checks passed
dm-vodopyanov pushed a commit to intel/llvm that referenced this pull request Jan 7, 2025
Batches the following bug fixes:

* oneapi-src/unified-runtime#2504
* oneapi-src/unified-runtime#2517
* oneapi-src/unified-runtime#2524

---------

Signed-off-by: Neil R. Spruit <[email protected]>
Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
kbenzie added a commit that referenced this pull request Jan 7, 2025
[L0]: Fix Out Event in Enqueue Wait Events to prevent reuse
kbenzie added a commit that referenced this pull request Jan 7, 2025
[L0]: Fix Out Event in Enqueue Wait Events to prevent reuse
kbenzie added a commit that referenced this pull request Jan 8, 2025
[L0]: Fix Out Event in Enqueue Wait Events to prevent reuse
kbenzie added a commit that referenced this pull request Jan 8, 2025
[L0]: Fix Out Event in Enqueue Wait Events to prevent reuse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge v0.11.x Include in the v0.11.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants