Fix invalid use of dlopen() #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
approved these changes
Jan 21, 2025
kbenzie
force-pushed
the
benie/cl-core-functions-no-dlopen
branch
from
72f3ce1 to
b9153f9
Compare
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Jan 22, 2025
When attempting to get a handle for the `libOpenCL.so` library in order to call `dlsym()` invalid arguments were set so `dlopen()` always returned null. This just happened to work due to the value of `RTLD_DEFAULT` being 0 so the `dlsym()` calls succeeded. This patch removes the invalid `dlopen()` usage and explicitly uses `RTLD_DEFAULT` instead of the null `handle`.
kbenzie
force-pushed
the
benie/cl-core-functions-no-dlopen
branch
from
b9153f9 to
264d046
Compare
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Jan 23, 2025
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Jan 24, 2025
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Jan 28, 2025
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to get a handle for the
libOpenCL.solibrary in order to calldlsym()invalid arguments were set sodlopen()always returned null. This just happened to work due to the value ofRTLD_DEFAULTbeing 0 so thedlsym()calls succeeded. This patch removes the invaliddlopen()usage and explicitly usesRTLD_DEFAULTinstead of the nullhandle.intel/llvm#16736