Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[UR][CUDA] Add tensor map APIs" #2610

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Revert "[UR][CUDA] Add tensor map APIs" #2610

wants to merge 2 commits into from

Conversation

npmiller
Copy link
Contributor

This patch reverts the following PR and its follow up build fix:

After further consideration it was decided that the only known use case for this extension would be better handled through interop, as a result this extension is no longer needed. This extension is CUDA specific and has no other known use cases than the aforementioned extension, which has now been dropped, so hopefully it should be fine to just remove.

@npmiller
Revert "Merge pull request oneapi-src#2502 from ldrumm/luke/tensormap…
aac2770 
…-version"

This reverts commit ad288bb, reversing
changes made to db491ab.
@npmiller
Revert "Merge pull request oneapi-src#1811 from hdelan/tensormap-exp-…
8d4be29 
…api"

This reverts commit 1851eff, reversing
changes made to 5f4a5a2.
@npmiller npmiller requested review from a team as code owners January 23, 2025 16:54
@npmiller npmiller requested a review from frasercrmck January 23, 2025 16:54
@github-actions github-actions bot added loader Loader related feature/bug specification Changes or additions to the specification experimental Experimental feature additions/changes/specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues opencl OpenCL adapter specific issues native-cpu Native CPU adapter specific issues labels Jan 23, 2025
Naghasan
Naghasan approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Naghasan Naghasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related closed PR intel/llvm#16247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naghasan Naghasan Naghasan approved these changes

@ldrumm ldrumm ldrumm approved these changes

@kbenzie kbenzie kbenzie approved these changes

@frasercrmck frasercrmck Awaiting requested review from frasercrmck frasercrmck is a code owner automatically assigned from oneapi-src/unified-runtime-hip-write

Assignees
No one assigned
Labels
cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@npmiller @kbenzie @ldrumm @Naghasan