[L0]: fix missing destroy of event given enqueue wait out event #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jan 24, 2025
-pre-commit PR for oneapi-src/unified-runtime#2612 Signed-off-by: Neil R. Spruit <[email protected]>
pbalcer
reviewed
Jan 24, 2025
nrspruit
force-pushed
the
destroy_wait_always
branch
from
200f075 to
bf0a598
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jan 24, 2025
-pre-commit PR for oneapi-src/unified-runtime#2612 Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
destroy_wait_always
branch
from
bf0a598 to
ad5534f
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jan 24, 2025
-pre-commit PR for oneapi-src/unified-runtime#2612 Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jan 24, 2025
-pre-commit PR for oneapi-src/unified-runtime#2612 Signed-off-by: Neil R. Spruit <[email protected]>
winstonzhang-intel
approved these changes
Jan 28, 2025
pbalcer
reviewed
Jan 28, 2025
nrspruit
force-pushed
the
destroy_wait_always
branch
from
ad5534f to
f832dd2
Compare
pbalcer
approved these changes
Jan 28, 2025
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jan 28, 2025
-pre-commit PR for oneapi-src/unified-runtime#2612 Signed-off-by: Neil R. Spruit <[email protected]>
- Added check during event handle release to perform an additional cleanup of an enqueue wait event once the user has released their usage of the out event. Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
destroy_wait_always
branch
from
f832dd2 to
21bf4be
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jan 28, 2025
-pre-commit PR for oneapi-src/unified-runtime#2612 Signed-off-by: Neil R. Spruit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup of an enqueue wait event once the user has released their
usage of the out event.