Add UR_KERNEL_INFO_SPILL_MEM_SIZE kernel info prop #2614
Conversation
| @@ -299,6 +299,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urKernelGetInfo(ur_kernel_handle_t hKernel, | |||
| hKernel->get())); | |||
| return ReturnValue(static_cast<uint32_t>(NumRegs)); | |||
| } | |||
| case UR_KERNEL_INFO_SPILL_MEM_SIZE: | |||
There was a problem hiding this comment.
for here and in the equivalent file in the hip adapter you'll need to explicitly add a return UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION; - right now it's falling through to return UR_RESULT_ERROR_INVALID_ENUMERATION; which isn't the expected return for an unsupported optional query
| @@ -299,6 +299,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urKernelGetInfo(ur_kernel_handle_t hKernel, | |||
| hKernel->get())); | |||
| return ReturnValue(static_cast<uint32_t>(NumRegs)); | |||
| } | |||
| case UR_KERNEL_INFO_SPILL_MEM_SIZE: | |||
There was a problem hiding this comment.
This should return UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION rather than UR_RESULT_ERROR_INVALID_ENUMERATION.
| @@ -234,6 +234,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urKernelGetInfo(ur_kernel_handle_t hKernel, | |||
| hKernel->get())); | |||
| return ReturnValue(static_cast<uint32_t>(NumRegs)); | |||
| } | |||
| case UR_KERNEL_INFO_SPILL_MEM_SIZE: | |||
There was a problem hiding this comment.
This should return UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION rather than UR_RESULT_ERROR_INVALID_ENUMERATION.
I see that in the native cpu adapter some other properties are also missing, e.g., |
Just this one should be fine, it's WIP. |
|
@pbalcer, what would be a proper way of implementing the v2 portion? The API now doesn't include the device handle which is needed to get the property through |
| @@ -624,6 +624,16 @@ ur_result_t urKernelGetInfo(ur_kernel_handle_t hKernel, | |||
| case UR_KERNEL_INFO_NUM_REGS: | |||
| case UR_KERNEL_INFO_NUM_ARGS: | |||
| return ReturnValue(uint32_t{hKernel->getCommonProperties().numKernelArgs}); | |||
| case UR_KERNEL_INFO_SPILL_MEM_SIZE: { | |||
| std::shared_lock<ur_shared_mutex> Guard(hKernel->getProgramHandle()->Mutex); | |||
There was a problem hiding this comment.
I took this from another similar implementation, assuming this protects the device retrieval call. Not sure if necessary, though.
| std::vector<uint32_t> spills(devices.size()); | ||
| for (size_t i = 0; i < spills.size(); ++i) { | ||
| spills[i] = uint32_t{hKernel->getProperties(devices[i]).spillMemSize}; | ||
| } | ||
| return ReturnValue(static_cast<const uint32_t *>(spills.data()), | ||
| spills.size()); |
There was a problem hiding this comment.
This relies on the ReturnValue to preserve the memory for the vector.
This allows for querying the information about produced register spills during kernel compilation. The query is optional and is only implemented for L0 now. The direct counterpart for the query is spillMemSize property returned by
zeKernelGetProperties.