Remove virtual from L0 V2 queues #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
level-zero
RossBrunton
force-pushed
the
ross/v2devirtqueue
branch
2 times, most recently
from
ab03c71 to
e451e84
Compare
|
This looks good to me in general. @igchor ? |
igchor
approved these changes
Jan 29, 2025
|
Looks, good. FYI, In V2 we also use virtual methods for buffers (memory.hpp). I'm actually working on support for images: #2640 so I can address this (remove the virtual functions) on that PR since I'm reworking that code anyway. |
pbalcer
approved these changes
Jan 30, 2025
|
@oneapi-src/unified-runtime-command-buffer-write Can I get a look at this? Effectively, I've split the queue handle into two types; one for the handle itself and one for the underlying queue. Command buffers now store a reference to the queue itself rather than the handle. |
Bensuo
reviewed
Jan 30, 2025
RossBrunton
force-pushed
the
ross/v2devirtqueue
branch
from
e451e84 to
858a2e4
Compare
Bensuo
approved these changes
Jan 30, 2025
|
Merging without LLVM commit since (as far as I know) there's no V2 testing there yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.