fix: allow graceful helmrelease takeover of helmfile apps

Signed-off-by: Devin Buhl <[email protected]>
onedr0p · Jan 8, 2025 · 71982fb · 71982fb
1 parent e115dd8
commit 71982fb
Show file tree

Hide file tree

Showing 6 changed files with 53 additions and 30 deletions.
diff --git a/kubernetes/main/apps/flux-system/flux/app/helm-values.yaml b/kubernetes/main/apps/flux-system/flux/app/helm-values.yaml
@@ -1,6 +1,11 @@
 ---
+# Graceful Helmfile to HelmRelease takeover
+x-shared-labels: &labels
+  helm.toolkit.fluxcd.io/name: flux
+  helm.toolkit.fluxcd.io/namespace: flux-system
+
 crds:
-  annotations: 
+  annotations:
     helm.sh/resource-policy: keep
 
 helmController:
@@ -15,6 +20,7 @@ helmController:
       - --feature-gates=OOMWatch=true
       - --oom-watch-memory-threshold=95
       - --oom-watch-interval=500ms
+  labels: *labels
   resources:
     requests:
       cpu: 100m
@@ -34,20 +40,23 @@ kustomizeController:
       # Ref: https://fluxcd.io/flux/installation/configuration/vertical-scaling/#increase-the-number-of-workers-and-limits
       - --concurrent=10
       - --requeue-dependency=5s
+  labels: *labels
   resources:
     requests:
       cpu: 100m
     limits:
       memory: 2Gi
 
 notificationController:
+  labels: *labels
   resources:
     requests:
       cpu: 100m
     limits:
       memory: 2Gi
 
 sourceController:
+  labels: *labels
   container:
     additionalArgs:
       # Enable Helm repositories caching

diff --git a/kubernetes/main/apps/flux-system/flux/app/helmrelease.yaml b/kubernetes/main/apps/flux-system/flux/app/helmrelease.yaml
@@ -19,6 +19,7 @@ spec:
       retries: 3
   upgrade:
     cleanupOnFail: true
+    disableWait: true
     remediation:
       strategy: rollback
       retries: 3

diff --git a/kubernetes/main/apps/kube-system/cilium/app/helm-values.yaml b/kubernetes/main/apps/kube-system/cilium/app/helm-values.yaml
@@ -78,3 +78,7 @@ securityContext:
       - NET_ADMIN
       - SYS_ADMIN
       - SYS_RESOURCE
+# Graceful Helmfile to HelmRelease takeover
+commonLabels:
+  helm.toolkit.fluxcd.io/name: cilium
+  helm.toolkit.fluxcd.io/namespace: kube-system
diff --git a/kubernetes/main/apps/kube-system/cilium/app/helmrelease.yaml b/kubernetes/main/apps/kube-system/cilium/app/helmrelease.yaml
@@ -25,32 +25,33 @@ spec:
   valuesFrom:
     - kind: ConfigMap
       name: cilium-helm-values
-  values:
-    hubble:
-      enabled: true
-      metrics:
-        enabled:
-          - dns:query
-          - drop
-          - tcp
-          - flow
-          - port-distribution
-          - icmp
-          - http
-        serviceMonitor:
-          enabled: true
-        dashboards:
-          enabled: true
-      relay:
-        enabled: true
-        rollOutPods: true
-        prometheus:
-          serviceMonitor:
-            enabled: true
-      ui:
-        enabled: true
-        rollOutPods: true
-        ingress:
-          enabled: true
-          className: internal
-          hosts: ["hubble.devbu.io"]
+  # Enable Hubble, Hubble Relay and Hubble UI
+  # values:
+  #   hubble:
+  #     enabled: true
+  #     metrics:
+  #       enabled:
+  #         - dns:query
+  #         - drop
+  #         - tcp
+  #         - flow
+  #         - port-distribution
+  #         - icmp
+  #         - http
+  #       serviceMonitor:
+  #         enabled: true
+  #       dashboards:
+  #         enabled: true
+  #     relay:
+  #       enabled: true
+  #       rollOutPods: true
+  #       prometheus:
+  #         serviceMonitor:
+  #           enabled: true
+  #     ui:
+  #       enabled: true
+  #       rollOutPods: true
+  #       ingress:
+  #         enabled: true
+  #         className: internal
+  #         hosts: ["hubble.devbu.io"]
diff --git a/kubernetes/main/apps/kube-system/coredns/app/helm-values.yaml b/kubernetes/main/apps/kube-system/coredns/app/helm-values.yaml
@@ -49,3 +49,7 @@ tolerations:
   - key: node-role.kubernetes.io/control-plane
     operator: Exists
     effect: NoSchedule
+# Graceful Helmfile to HelmRelease takeover
+customLabels:
+  helm.toolkit.fluxcd.io/name: coredns
+  helm.toolkit.fluxcd.io/namespace: kube-system
diff --git a/kubernetes/main/apps/kube-system/spegel/app/helm-values.yaml b/kubernetes/main/apps/kube-system/spegel/app/helm-values.yaml
@@ -10,3 +10,7 @@ serviceMonitor:
   enabled: true
 grafanaDashboard:
   enabled: true
+# Graceful Helmfile to HelmRelease takeover
+commonLabels:
+  helm.toolkit.fluxcd.io/name: spegel
+  helm.toolkit.fluxcd.io/namespace: kube-system