Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only try cronjobs once and stop pinging me #8410

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Conversation

onedr0p
Copy link
Owner

@onedr0p onedr0p commented Nov 28, 2024

No description provided.

Signed-off-by: Devin Buhl <[email protected]>
@bot-ross bot-ross bot added area/kubernetes Changes made in the kubernetes directory cluster/main labels Nov 28, 2024
@bot-ross
Copy link
Contributor

bot-ross bot commented Nov 28, 2024

--- HelmRelease: default/recyclarr CronJob: default/recyclarr

+++ HelmRelease: default/recyclarr CronJob: default/recyclarr

@@ -14,13 +14,13 @@

   startingDeadlineSeconds: 30
   schedule: '@daily'
   successfulJobsHistoryLimit: 1
   failedJobsHistoryLimit: 1
   jobTemplate:
     spec:
-      ttlSecondsAfterFinished: 3600
+      ttlSecondsAfterFinished: 86400
       backoffLimit: 0
       template:
         metadata:
           labels:
             app.kubernetes.io/component: recyclarr
             app.kubernetes.io/instance: recyclarr
--- HelmRelease: default/qbtools CronJob: default/qbtools-orphaned

+++ HelmRelease: default/qbtools CronJob: default/qbtools-orphaned

@@ -36,13 +36,13 @@

             seccompProfile:
               type: RuntimeDefault
           hostIPC: false
           hostNetwork: false
           hostPID: false
           dnsPolicy: ClusterFirst
-          restartPolicy: OnFailure
+          restartPolicy: Never
           containers:
           - args:
             - orphaned
             - --exclude-pattern
             - '*_unpackerred*'
             env:
--- HelmRelease: default/qbtools CronJob: default/qbtools-tagging

+++ HelmRelease: default/qbtools CronJob: default/qbtools-tagging

@@ -36,13 +36,13 @@

             seccompProfile:
               type: RuntimeDefault
           hostIPC: false
           hostNetwork: false
           hostPID: false
           dnsPolicy: ClusterFirst
-          restartPolicy: OnFailure
+          restartPolicy: Never
           initContainers:
           - args:
             - tagging
             - --added-on
             - --expired
             - --last-activity

@bot-ross
Copy link
Contributor

bot-ross bot commented Nov 28, 2024

--- kubernetes/main/apps/default/plex/tools Kustomization: flux-system/plex-tools HelmRelease: default/plex-off-deck

+++ kubernetes/main/apps/default/plex/tools Kustomization: flux-system/plex-tools HelmRelease: default/plex-off-deck

@@ -49,12 +49,14 @@

           backoffLimit: 0
           concurrencyPolicy: Forbid
           failedJobsHistory: 1
           schedule: '@hourly'
           successfulJobsHistory: 1
           ttlSecondsAfterFinished: 3600
+        pod:
+          restartPolicy: Never
         type: cronjob
     persistence:
       secret-file:
         globalMounts:
         - path: /config/config.ini
           readOnly: true
--- kubernetes/main/apps/default/qbittorrent/tools Kustomization: flux-system/qbittorrent-tools HelmRelease: default/qbtools

+++ kubernetes/main/apps/default/qbittorrent/tools Kustomization: flux-system/qbittorrent-tools HelmRelease: default/qbtools

@@ -103,13 +103,13 @@

           failedJobsHistory: 1
           schedule: '@weekly'
           successfulJobsHistory: 1
           suspend: true
           ttlSecondsAfterFinished: 3600
         pod:
-          restartPolicy: OnFailure
+          restartPolicy: Never
         type: cronjob
       reannounce:
         containers:
           app:
             args:
             - reannounce
@@ -246,13 +246,13 @@

               allowPrivilegeEscalation: false
               capabilities:
                 drop:
                 - ALL
               readOnlyRootFilesystem: true
         pod:
-          restartPolicy: OnFailure
+          restartPolicy: Never
         type: cronjob
     defaultPodOptions:
       securityContext:
         runAsGroup: 568
         runAsNonRoot: true
         runAsUser: 568
--- kubernetes/main/apps/default/recyclarr/app Kustomization: flux-system/recyclarr HelmRelease: default/recyclarr

+++ kubernetes/main/apps/default/recyclarr/app Kustomization: flux-system/recyclarr HelmRelease: default/recyclarr

@@ -58,13 +58,15 @@

         cronjob:
           backoffLimit: 0
           concurrencyPolicy: Forbid
           failedJobsHistory: 1
           schedule: '@daily'
           successfulJobsHistory: 1
-          ttlSecondsAfterFinished: 3600
+          ttlSecondsAfterFinished: 86400
+        pod:
+          restartPolicy: Never
         type: cronjob
     defaultPodOptions:
       securityContext:
         fsGroup: 568
         fsGroupChangePolicy: OnRootMismatch
         runAsGroup: 568

@onedr0p onedr0p changed the title feat: enhance all cronjobs feat: only try cronjobs once and stop pinging me Nov 28, 2024
@onedr0p onedr0p merged commit 0820951 into main Nov 28, 2024
10 checks passed
@onedr0p onedr0p deleted the need-to-see-the-diff branch November 28, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes Changes made in the kubernetes directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant