Bugfix #23: Update on limiter constants (#25)

* Adding reservoir limitations * Changing limiter constants per bug #23 * Update package.json & node-fetch version Co-authored-by: James Li <[email protected]>
onfleet · Oct 7, 2020 · 640610c · 640610c
1 parent 1acaf7c
commit 640610c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/lib/Methods.js b/lib/Methods.js
@@ -11,6 +11,7 @@ const {
 
 // Create new rate limiter using defined constants
 const limiter = new Bottleneck({
+  reservoir: constants.LIMITER_RESERVOIR,
   reservoirRefreshInterval: constants.LIMITER_REFRESH_INTERVAL,
   maxConcurrent: constants.LIMITER_MAX_CONCURRENT,
   minTime: constants.LIMITER_MIN_TIME,

diff --git a/lib/constants.js b/lib/constants.js
@@ -1,6 +1,7 @@
 const constants = {
+  LIMITER_RESERVOIR: 20,
   LIMITER_REFRESH_INTERVAL: 250,
-  LIMITER_MAX_CONCURRENT: 5,
+  LIMITER_MAX_CONCURRENT: 1,
   LIMITER_MIN_TIME: 50,
 };
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@onfleet/node-onfleet",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "Official client library for accessing the Onfleet API",
   "main": "index.js",
   "scripts": {
@@ -21,7 +21,7 @@
   "homepage": "https://onfleet.com/",
   "dependencies": {
     "bottleneck": "^2.19.5",
-    "node-fetch": "^2.6.0"
+    "node-fetch": "^2.6.1"
   },
   "devDependencies": {
     "chai": "^4.2.0",