Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Word128 integer type #2497

Merged
merged 17 commits into from
May 26, 2023
Merged

Conversation

darkdrag00nv2
Copy link
Contributor

@darkdrag00nv2 darkdrag00nv2 commented May 15, 2023

Work towards #2389
Work towards onflow/developer-grants#179

Description

This PR introduces the type Word128 to Cadence.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@darkdrag00nv2 darkdrag00nv2 marked this pull request as ready for review May 17, 2023 14:51
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #2497 (d3de346) into master (ed98581) will decrease coverage by 0.11%.
The diff coverage is 62.88%.

@@            Coverage Diff             @@
##           master    #2497      +/-   ##
==========================================
- Coverage   78.55%   78.45%   -0.11%     
==========================================
  Files         336      336              
  Lines       76044    76561     +517     
==========================================
+ Hits        59739    60068     +329     
- Misses      14099    14262     +163     
- Partials     2206     2231      +25     
Flag Coverage Δ
unittests 78.45% <62.88%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
encoding/ccf/traverse_value.go 98.30% <ø> (ø)
runtime/interpreter/hashablevalue.go 100.00% <ø> (ø)
runtime/interpreter/primitivestatictype_string.go 100.00% <ø> (ø)
runtime/interpreter/visitor.go 8.51% <0.00%> (-0.19%) ⬇️
runtime/interpreter/value.go 69.08% <53.54%> (-0.46%) ⬇️
runtime/interpreter/encode.go 67.27% <66.66%> (-0.01%) ⬇️
types.go 85.66% <66.66%> (-0.13%) ⬇️
encoding/json/decode.go 88.33% <68.75%> (-0.32%) ⬇️
runtime/interpreter/decode.go 46.61% <70.58%> (+0.27%) ⬆️
values.go 76.08% <80.00%> (+0.10%) ⬆️
... and 13 more

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

runtime/sema/type.go Outdated Show resolved Hide resolved
runtime/sema/type_tags.go Outdated Show resolved Hide resolved
runtime/tests/interpreter/builtinfunctions_test.go Outdated Show resolved Hide resolved
values.go Outdated Show resolved Hide resolved
values_test.go Outdated Show resolved Hide resolved
@darkdrag00nv2 darkdrag00nv2 requested a review from turbolent May 18, 2023 17:42
@turbolent turbolent self-assigned this May 24, 2023
encoding/ccf/decode.go Show resolved Hide resolved
encoding/json/decode.go Show resolved Hide resolved
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

runtime/sema/type_tags.go Outdated Show resolved Hide resolved
@darkdrag00nv2
Copy link
Contributor Author

Had to force push after resolving merge conflicts.

@darkdrag00nv2 darkdrag00nv2 requested a review from turbolent May 26, 2023 18:50
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@turbolent turbolent merged commit 326312c into onflow:master May 26, 2023
@darkdrag00nv2 darkdrag00nv2 deleted the word128_256_2389 branch May 26, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants