-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple interpreter values from interpreter #3698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 68a0460 Collapsed results for better readability
|
6 tasks
jsproz
approved these changes
Feb 6, 2025
SupunS
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #3693
Description
Demonstrate how we could decouple methods of
interpreter.Value
types fromInterpreter
.In particular, define interfaces for the functionality that is required by implementations of the
Value.StaticType
method and change the parameter type fromInterpreter
to the new combined interface (for now calledStaticTypeGetter
, for lack of a better name – suggestions are very welcome).Most implementations of
Value.StaticType
only need to perform memory metering, so need acommon.MemoryGauge
. However,StorageReferenceValue.StaticType
dereferences, which requires access to storage and a means to convert a static type to a sema type.If this approach looks good, we can gradually refactor other methods of
Value
in a similar way.Suggestions for improvements or alternatives are very welcome!
master
branchFiles changed
in the Github PR explorer