Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compiler] Compile if-let #3756

Merged
merged 2 commits into from
Feb 4, 2025
Merged

[Compiler] Compile if-let #3756

merged 2 commits into from
Feb 4, 2025

Conversation

turbolent
Copy link
Member

Work towards #3742

Description

  • Compile if let statements
  • Add JumpIfNil instruction
  • Add operand stack effects for JumpIf* instructions
  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz February 4, 2025 01:36
@turbolent turbolent self-assigned this Feb 4, 2025
@turbolent turbolent requested a review from SupunS as a code owner February 4, 2025 01:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit 03ea43b
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent mentioned this pull request Feb 4, 2025
Merged
6 tasks
SupunS
SupunS approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

@turbolent turbolent merged commit 5adeea2 into feature/compiler Feb 4, 2025
9 checks passed
@turbolent turbolent deleted the bastian/compile-if-let branch February 4, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsproz jsproz jsproz approved these changes

@SupunS SupunS SupunS approved these changes

Assignees

@turbolent turbolent

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turbolent @jsproz @SupunS