Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supported suggested features by apps #161

Merged
merged 11 commits into from
Oct 3, 2023
Merged

Supported suggested features by apps #161

merged 11 commits into from
Oct 3, 2023

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented Sep 6, 2023 •
edited
Loading

Addresses: #158

Screenshot 2023-09-08 at 10 10 45 AM

@chasefleming chasefleming requested a review from a team as a code owner September 6, 2023 17:27
@vercel
Copy link

vercel bot commented Sep 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fcl-discovery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 10:25pm

nialexsan
nialexsan reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@nialexsan nialexsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we call the key just FEATURES or SUPPORTED_FEATURES instead of SUGGESTED_FEATURES?

package.json Show resolved Hide resolved
@chasefleming
Copy link
Member Author

chasefleming commented Sep 7, 2023 •
edited
Loading

should we call the key just FEATURES or SUPPORTED_FEATURES instead of SUGGESTED_FEATURES?

I'd probably rather be explicit since I left features as an object so other things beyond suggested could be added in the future and that object looks like { "features": { "suggested": [] } }

jribbink
jribbink requested changes Sep 7, 2023
View reviewed changes
helpers/constants.js Outdated Show resolved Hide resolved
components/ServiceCard.tsx Outdated Show resolved Hide resolved
data/metadata.json Outdated Show resolved Hide resolved
data/metadata.json Outdated Show resolved Hide resolved
@chasefleming @jribbink
Update helpers/constants.js
b67f5c8 
Co-authored-by: Jordan Ribbink <[email protected]>
@JeffreyDoyle JeffreyDoyle merged commit c35058d into master Oct 3, 2023
2 checks passed
@JeffreyDoyle JeffreyDoyle deleted the cf/suggested-features branch October 3, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jribbink jribbink jribbink approved these changes

@JeffreyDoyle JeffreyDoyle JeffreyDoyle approved these changes

@nialexsan nialexsan Awaiting requested review from nialexsan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chasefleming @nialexsan @JeffreyDoyle @jribbink