-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add previewnet entry into service #180
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also need to change any mentions of crescendo
to previewnet
in the codebase.
I only found one instance of "crescendo" of which I updated in this PR. Is there other places I need to look outside of this repo? |
Ok looks like it was already changed to previewnet everwhere else, except the services key wasn't so should be good: https://github.com/onflow/fcl-discovery/blob/master/helpers/constants.js#L8 Have you tested this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but one more spot to check might be to make sure nothing needs to be different in the metadata for previewnet: https://github.com/onflow/fcl-discovery/blob/master/data/metadata.json
add previewnet entry into service