Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add previewnet entry into service #180

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

bthaile
Copy link
Contributor

@bthaile bthaile commented Apr 23, 2024

add previewnet entry into service

@bthaile bthaile requested a review from a team as a code owner April 23, 2024 18:03
Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fcl-discovery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 6:04pm

Copy link
Member

@chasefleming chasefleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to change any mentions of crescendo to previewnet in the codebase.

@bthaile
Copy link
Contributor Author

bthaile commented Apr 23, 2024

You'll also need to change any mentions of crescendo to previewnet in the codebase.

I only found one instance of "crescendo" of which I updated in this PR. Is there other places I need to look outside of this repo?

@chasefleming
Copy link
Member

Ok looks like it was already changed to previewnet everwhere else, except the services key wasn't so should be good: https://github.com/onflow/fcl-discovery/blob/master/helpers/constants.js#L8

Have you tested this?

@bthaile
Copy link
Contributor Author

bthaile commented Apr 23, 2024

Yes, tested it locally using flow port. I added a previewnet network configuration to flow port. Not sure if there are cases for flow port to support previewnet, other than me updating scripts and transactions to be cadence v1 compat. I might be good to test locally only.

image

Copy link
Member

@chasefleming chasefleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but one more spot to check might be to make sure nothing needs to be different in the metadata for previewnet: https://github.com/onflow/fcl-discovery/blob/master/data/metadata.json

@bthaile bthaile merged commit 9adcccb into master Apr 24, 2024
3 checks passed
@bthaile bthaile deleted the add-previewnet-discovery branch April 24, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants