Add integrated WalletConnect QR when available #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jribbink
force-pushed
the
jribbink/scan-qr
branch
from
04b0fe4
to
0fabc37
Compare
jribbink
force-pushed
the
jribbink/scan-qr
branch
from
700d846
to
c2e11b0
Compare
jribbink
force-pushed
the
jribbink/scan-qr
branch
from
c2e11b0
to
8469846
Compare
jribbink
changed the title
chasefleming
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #209
New functionality depends on FCL-JS changes to work correctly. Falls back to old WalletConnect modal with older FCL-JS versions
Page is a bit of a placeholder right now. Need to go in and do a refactor of QR rendering, so will add styling (e.g. QR styling & logo in centre) later.