Switch to custom-rendered QR codes #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jribbink
force-pushed
the
jribbink/enhance-qr
branch
from
266b1e7
to
cd23244
Compare
chasefleming
approved these changes
Aug 7, 2024
| context = document.documentElement, | ||
| ) { | ||
| // Create a temporary element | ||
| const tempEl = document.createElement('div') |
There was a problem hiding this comment.
This is expensive. You could reuse a hidden element here if you wanted to optimize more for performance. You could also cache the result in a map by size.
There was a problem hiding this comment.
The QRCode component is memoized, but yea makes sense to do this indidividual function as well. I'll wrap this in a useMemo 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212