Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network to mixpanel metrics #1864

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Add network to mixpanel metrics #1864

merged 2 commits into from
Dec 16, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Dec 16, 2024

Closes #1863

Description

Adds value of the network flag to metrics


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Dec 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.55%. Comparing base (f529b1f) to head (e02d00f).

Files with missing lines Patch % Lines
internal/command/command.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1864      +/-   ##
==========================================
- Coverage   28.55%   28.55%   -0.01%     
==========================================
  Files          95       95              
  Lines        6524     6525       +1     
==========================================
  Hits         1863     1863              
- Misses       4479     4480       +1     
  Partials      182      182              
Flag Coverage Δ
unittests 28.55% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink merged commit cfd82e0 into master Dec 16, 2024
5 checks passed
@jribbink jribbink deleted the jribbink/network-metric branch December 16, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add network flag to metrics
3 participants