[Access] Add endpoints to Execution nodes to support getting Transaction Result error messages #5042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiDiachuk
requested review from
gomisha,
yhassanzadeh13,
peterargue and
ramtinms
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5042 +/- ##
==========================================
- Coverage 56.20% 56.19% -0.02%
==========================================
Files 975 975
Lines 90714 90833 +119
==========================================
+ Hits 50990 51047 +57
- Misses 35913 35970 +57
- Partials 3811 3816 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
reviewed
Nov 21, 2023
|
I've accidentally pushed a version which wasn't properly structured while I was trying some tests refactoring. I've fixed everything and there is a clean diff with only additions. |
|
@peterargue Thanks for comments. Added missing parts and now it's ready for review again. |
peterargue
approved these changes
Nov 22, 2023
Co-authored-by: Peter Argue <[email protected]>
peterargue
pushed a commit
that referenced
this pull request
Dec 12, 2023
…dpoints-to-execution-nods-to-support-tx-result-err-msgs [Access] Add endpoints to Execution nodes to support getting Transaction Result error messages
peterargue
pushed a commit
that referenced
this pull request
Dec 12, 2023
…dpoints-to-execution-nods-to-support-tx-result-err-msgs [Access] Add endpoints to Execution nodes to support getting Transaction Result error messages
peterargue
pushed a commit
that referenced
this pull request
Dec 13, 2023
…dpoints-to-execution-nods-to-support-tx-result-err-msgs [Access] Add endpoints to Execution nodes to support getting Transaction Result error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4754
In this pull request are Introduced new endpoints on the Execution node grpc API, that return transaction result error messages.
Related PR:
onflow/flow#1398