Adds NFTStorefrontV2 and USDCFlow to bootstrapping

[joshuahannan]

Closes onflow/flow-emulator#535

Adds the NFTStorefrontV2 and USDCFlow smart contracts to the flow-go bootstrapping so they are automatically deployed to the emulator. Will make it easier for developers to test with these contracts without having to deploy them themselves.

[turbolent]

Good idea to add these contracts! If the goal is to add these for mostly developer convenience, then the Emulator might be a better place to add this.

Not sure if customizing/extending the bootstrapping is already possible so it can be done in the Emulator alone – if not maybe that's something that should be done here in flow-go, and then what the PR currently does (adding the contracts) should be moved to the Emulator.

[bluesign]

@turbolent yeah this never realized unfortunately #2812

maybe we can reopen the issue and then move things to emulator.

[joshuahannan]

Just taking a look at this again. What do we think is the best thing to do here? It is certainly easier for me to just do it like in this PR, but I totally understand if we'd rather use the emulator. Just will take some extra work for us to get that other emulator feature working and build in the deployment there

[bluesign]

I am a bit torn here; on one hand I like the idea of Foundation contracts to be bootstrapped, on the other hand, it is hard to retire stuff from bootstrap I guess. ( not sure if this is 100% true, just my guess )

I would vote for customized bootstrap, with this contract behind an option on bootstrap. ( in the mean time we can maybe put others also behind a flag )

[janezpodhostnik]

See my comment on #2812 (comment).

For not I'm not opposed to adding these two new contracts to flow-go if they help developers (and us).

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.11%. Comparing base (a80d14d) to head (e7c3957).

Files with missing lines	Patch %	Lines
utils/unittest/execution_state.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6611      +/-   ##
==========================================
+ Coverage   41.09%   41.11%   +0.02%     
==========================================
  Files        2119     2119              
  Lines      185897   185938      +41     
==========================================
+ Hits        76390    76453      +63     
+ Misses     103095   103075      -20     
+ Partials     6412     6410       -2     

Flag	Coverage Δ
unittests	41.11% <95.34%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joshuahannan]

Can I get an approval here? It doesn't seem like we're going to get the emulator bootstrapping work done any time soon, so I'd like to just get this in if possible so we have it

[joshuahannan]

@onflow/cadence Can I get an approval here? Thank you!

[turbolent]

This is unrelated to Cadence, this should be reviewed by the execution/protocol team