Refactor Export EVM State and Compare State Diff #6760
Merged
+505
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
changed the base branch from
leo/add-verify-evm-offchain-replay
to
master
zhangchiqing
force-pushed
the
leo/export-evm-state-from-gobs
branch
from
0cfb7f5 to
ce205ac
Compare
zhangchiqing
changed the base branch from
master
to
leo/add-verify-evm-offchain-replay
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6760 +/- ##
==========================================
- Coverage 41.04% 40.98% -0.07%
==========================================
Files 2076 2079 +3
Lines 183653 183922 +269
==========================================
- Hits 75387 75379 -8
- Misses 101965 102243 +278
+ Partials 6301 6300 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
force-pushed
the
leo/export-evm-state-from-gobs
branch
from
ce205ac to
9765935
Compare
zhangchiqing
force-pushed
the
leo/export-evm-state-from-gobs
branch
from
d49ee00 to
be99b16
Compare
zhangchiqing
force-pushed
the
leo/export-evm-state-from-gobs
branch
from
b34650d to
cf32688
Compare
janezpodhostnik
approved these changes
Dec 2, 2024
| // Testnet51 - Height Coordinated Upgrade 1 | ||
| // Flow Block: 212562161 1a520608c5457f228405c4c30fc39c8a0af7cf915fb2ede7ec5ccffc2a000f57 | ||
| // PR: https://github.com/onflow/flow-go/pull/6380 | ||
| const coinbaseAddressChangeEVMHeightTestnet = 1385491 | ||
| const coinbaseAddressChangeEVMHeightTestnet = 1385490 |
There was a problem hiding this comment.
Is this now the correct height?
Comment on lines
86
to
89
| // Testnet52 - Spork | ||
| // Flow Block: 218215350 cc7188f0bdac4c442cc3ee072557d7f7c8ca4462537da945b148d5d0efa7a1ff | ||
| // PR: https://github.com/onflow/flow-go/pull/6377 | ||
| // const blockHashListBugIntroducedHCUEVMHeightTestnet = 7038679 |
There was a problem hiding this comment.
can we just delete this
zhangchiqing
force-pushed
the
leo/add-verify-evm-offchain-replay
branch
from
556d903 to
1bdc486
Compare
peterargue
approved these changes
Dec 4, 2024
zhangchiqing
force-pushed
the
leo/export-evm-state-from-gobs
branch
from
be05483 to
2d4bb10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work towards: onflow/flow-evm-gateway#720
This PR refactors the EVM state exporting and importing as well as comparing the EVM state diff.