Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Collection] Reduce log level in provider #6931

Merged
merged 1 commit into from
Jan 24, 2025
Merged

[Collection] Reduce log level in provider #6931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions engine/common/provider/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,14 @@ func (e *Engine) processEntityRequestWorker(ctx irrecoverable.SignalerContext, r
lg.Trace().Msg("worker picked up entity request for processing")
err := e.onEntityRequest(request)
if err != nil {
if engine.IsInvalidInputError(err) || engine.IsNetworkTransmissionError(err) {
lg.Error().Err(err).Msg("worker could not process entity request")
if engine.IsInvalidInputError(err) {
// log at debug level since nodes that recently unstaked are allowed to communicate over
// the network, but not allowed to request entities. Even an honest node may have been
// behind processing blocks and inadvertently continue requesting entities after they
// have left the network.
lg.Debug().Err(err).Msg("could not process entity request: invalid request")
} else if engine.IsNetworkTransmissionError(err) {
lg.Error().Err(err).Msg("could not process entity request: transmit error")
} else {
// this is an unexpected error, we crash the node.
ctx.Throw(err)
Expand Down
Loading