Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for PR #52 #69

Merged
merged 80 commits into from
Jul 24, 2024
Merged

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Jul 23, 2024

suggestions for #52

  • extend KMAC128 tests with an output size larger than 32 and an expected test vector
  • update KMAC128 output size in the hashing algos list from 128 to 256
  • update HasherImpl to enforce keys are customizers are only used for KMAC128
  • added tests for more invalid inputs
    • non-nil keys for non-KMAC algos
    • non-nil customizers for non-KMAC algos
    • invalid output size for non-KMAC algos
    • non-supported hashing algo

Copy link
Contributor

coderabbitai bot commented Jul 23, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tarakby tarakby changed the title Tarak/hashing suggestions Suggestion for PR #52 Jul 23, 2024
Copy link

github-actions bot commented Jul 23, 2024

Unit Test Results

  53 files  +  53    53 suites  +53   22s ⏱️ +22s
303 tests +303  302 ✔️ +302  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit a09aaff. ± Comparison against base commit 471c53b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 23, 2024

Integration Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a09aaff. ± Comparison against base commit 471c53b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 24, 2024

SDK Examples Unit Test Results

2 files  2 suites   2s ⏱️
6 tests 6 ✔️ 0 💤 0 ❌

Results for commit a09aaff.

♻️ This comment has been updated with latest results.

@lealobanov
Copy link
Collaborator

@tarakby just had a look at the changes and I think everything looks good, I am rebasing against main to account for all the changed file paths and fixed the failing build due to linter. As soon as build passes will go ahead and merge this, thanks!

@lealobanov
Copy link
Collaborator

@tarakby @franklywatson There is currently one failing test against the emulator which seems to be coming from the Cadence index, so will go ahead and merge this and resolve in #52 . Thanks!

@lealobanov lealobanov merged commit 54de05a into hashing-algorithms Jul 24, 2024
3 of 5 checks passed
@tarakby tarakby deleted the tarak/hashing-suggestions branch July 27, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants