-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion for PR #52 #69
Conversation
Setting up new Access API methods
Migrating SDK examples repo into multi-module project structure
Move inline JSON to standalone files
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Unit Test Results 53 files + 53 53 suites +53 22s ⏱️ +22s For more details on these failures, see this check. Results for commit a09aaff. ± Comparison against base commit 471c53b. ♻️ This comment has been updated with latest results. |
SDK Examples Unit Test Results2 files 2 suites 2s ⏱️ Results for commit a09aaff. ♻️ This comment has been updated with latest results. |
@tarakby just had a look at the changes and I think everything looks good, I am rebasing against main to account for all the changed file paths and fixed the failing build due to linter. As soon as build passes will go ahead and merge this, thanks! |
@tarakby @franklywatson There is currently one failing test against the emulator which seems to be coming from the Cadence index, so will go ahead and merge this and resolve in #52 . Thanks! |
suggestions for #52
HasherImpl
to enforce keys are customizers are only used for KMAC128