Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Access] Implement gRPC streaming endpoint SubscribeAccountStatuses #1433

Merged
merged 15 commits into from
Mar 29, 2024
Merged

[Access] Implement gRPC streaming endpoint SubscribeAccountStatuses #1433

merged 15 commits into from
Mar 29, 2024

Conversation

AndriiDiachuk
Copy link
Contributor

In this PR was Introduced changes in proto for a new endpoint named SubscribeAccountStatuses.

@AndriiDiachuk AndriiDiachuk mentioned this pull request Feb 16, 2024
Merged
@AndriiDiachuk AndriiDiachuk marked this pull request as ready for review February 20, 2024 17:09
peterargue
peterargue reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few comments about comments. but the structure looks good.

protobuf/flow/executiondata/executiondata.proto Outdated Show resolved Hide resolved
protobuf/flow/executiondata/executiondata.proto Outdated Show resolved Hide resolved
protobuf/flow/executiondata/executiondata.proto Outdated Show resolved Hide resolved
protobuf/flow/executiondata/executiondata.proto Outdated Show resolved Hide resolved
protobuf/flow/executiondata/executiondata.proto Outdated Show resolved Hide resolved
protobuf/go/flow/access/access_grpc.pb.go Outdated Show resolved Hide resolved
peterargue
peterargue reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@peterargue peterargue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but can you upgrade your protoc-gen-go-grpc to v1.3.0. looks like it regenerated a few unrelated protobufs because your version is out of date.

@peterargue peterargue merged commit 9f04832 into onflow:master Mar 29, 2024
1 check passed
@AndriiDiachuk AndriiDiachuk deleted the AndriiDiachuk/access-grpc-streaming-endpoint-SubscribeAccountStatuses branch July 10, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durkmurder durkmurder durkmurder left review comments

@peterargue peterargue peterargue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriiDiachuk @durkmurder @peterargue