This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
QR Code Decoder: Correct evenLengthDigitsRegex #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently only checks that the string contains 2 consecutive digits. It matches '123' and 'a 12'.
|
Thank you so much @juharris We are working through the policy and process challenges with accepting pull requests from the community. I will report back with updates as we move things along. |
|
It's also checking that it just has digits.
…On Wed., Oct. 27, 2021, 10:05 Patrick Doyle, ***@***.***> wrote:
Are you really using a regex just to check whether the number of
characters in a string is even? Talk about bringing a trebuchet to a knife
fight.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMFJCI6FWOO6W2E3PE2QLLUJABKLANCNFSM5GGZ2TPQ>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT TESTED
The regex currently only checks that the string contains 2 consecutive digits. It matches '123' and 'a 12'.