Fixed Tautrimas comments and added basic pipeline documentation. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,7 @@ | |||
| use ONGR\ConnectionsBundle\Pipeline\Event\ItemPipelineEvent; | |||
|
|
|||
| /** | |||
| * AbstractConsumeEventListener class. | |||
| * Handles basic item skipping when there is nothing to do on skip. | |||
There was a problem hiding this comment.
This sentence becomes clear after reading it several times and also reading the code. Not sure if that's so great, but it's not that bad, either.
GrandLTU
force-pushed
the
pipiline_skip
branch
from
9e87475 to
d3ab2fe
Compare
| When ``ItemSkipException`` is thrown by the modifier, pipeline catches it and sets skipException | ||
| value in ``ItemPipelineEvent``. | ||
|
|
||
| When modifier throws ``ItemSkipException`` pipeline catches it and sets skipException in ``ItemPipelineEvent``. |
There was a problem hiding this comment.
the text is almost the same as above..
trylika
added a commit
that referenced
this pull request
Jan 20, 2015
Fixed Tautrimas comments and added basic pipeline documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments from #99