Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit tree growth to the system recursion limit #1585

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

e10e3
Copy link
Contributor

@e10e3 e10e3 commented Jul 26, 2024

Python's recursion limit is obtained with sys.getrecursionlimit(). In this PR, trees will stop at 20 before the limit, to ensure the calling program has enough headroom.

How many "steps" before the limit should be kept (here 20) is open to discussion.

Fixes #1578

@smastelini smastelini marked this pull request as ready for review July 29, 2024 12:15
@smastelini
Copy link
Member

Thank you so much, @e10e3. I will check the Hoeffding Tree guidelines separately.

@smastelini smastelini merged commit 192d1ca into online-ml:main Jul 29, 2024
4 checks passed
@e10e3 e10e3 deleted the tree-max-depth branch August 22, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SRP can cause a recursion error on large datasets
2 participants