Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the class CentralMoments #1593

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

e10e3
Copy link
Contributor

@e10e3 e10e3 commented Aug 22, 2024

This was a utility class internal to River, and the last references to it were removed in a previous version of the library, with the move to Rust statistics.

It inherits from stats.base.Univariate, but does not implement any of the abstract methods. As a consequence, creating an instance throws a TypeError.

Closes: #1591

This was a utility class internal to River, and the last references to
it were removed in a previous version of the library, with the move to
Rust statistics.
@e10e3 e10e3 requested a review from AdilZouitine as a code owner August 22, 2024 09:56
@e10e3
Copy link
Contributor Author

e10e3 commented Aug 22, 2024

Is it worth adding a changelog entry? It has no public method (not counting the constructor) and was not exported by the statsmodule.
But we are still removing a non-private class.

@MaxHalford
Copy link
Member

Is it worth adding a changelog entry? It has no public method (not counting the constructor) and was not exported by the statsmodule.

It doesn't cost much to mention it, so I would do it 👍

@e10e3 e10e3 requested a review from smastelini as a code owner August 22, 2024 12:02
@MaxHalford MaxHalford merged commit 71a127f into online-ml:main Aug 22, 2024
4 checks passed
@e10e3 e10e3 deleted the remove-centralmoments branch August 22, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The class CentralMoments from module stats cannot be instantiated
2 participants