use post request and correct content type #1
Conversation
src/api_client/mod.rs
Outdated
| @@ -173,7 +173,7 @@ impl racal::reqwest::ApiClient<NoAuthentication> for UnauthenticatedCVR { | |||
| &self, req: RequestBuilder, | |||
| ) -> Result<RequestBuilder, racal::reqwest::ApiError> { | |||
| self.http_rate_limiter.until_ready().await; | |||
| Ok(req) | |||
| Ok(req.header("Content-Type", "application/json")) | |||
There was a problem hiding this comment.
This should be added to ApiConfiguration::to_headers instead, as some requests may want to overwrite this, and setting it explicitly always just before making the requests would stop that.
There was a problem hiding this comment.
yeah I've looked into this a bit more and I'd say it should be included in the racal package anyway since the body function inside of Queryable returns an Option with a serde_json::Result and I think it's safe to assume that if something is there then it's json data.
but correct me if anything I've said here is wrong since I'm not fully confident about this
I also found that neos_rs had the same header issue, so fixing it only in this package wouldn't actually fix everything
There was a problem hiding this comment.
Eeeh, could provide it as a default there, but other types of data can be posted too, for example I'd expect that image uploads might be a thing that would be neat to support, so it would need to at least be something that can be overridden in the end...
without these changes this library failed to log in every time for me...