order currencies in call to remove test flakiness

onlydustxyz · Dec 22, 2023 · 327407d · 327407d
1 parent 88e880b
commit 327407d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/api/tests/resources/wiremock/coinmarketcap/mappings/cryptocurrency-quotes.json b/api/tests/resources/wiremock/coinmarketcap/mappings/cryptocurrency-quotes.json
@@ -1,6 +1,6 @@
 {
     "request": {
-        "url": "/v2/cryptocurrency/quotes/latest?id=1027%2C11840%2C21794%2C17445%2C3408&convert=USD",
+        "url": "/v2/cryptocurrency/quotes/latest?id=1027%2C11840%2C17445%2C21794%2C3408&convert=USD",
         "method": "GET",
         "headers": {
             "X-CMC_PRO_API_KEY": {

diff --git a/common/infrastructure/src/coinmarketcap/mod.rs b/common/infrastructure/src/coinmarketcap/mod.rs
@@ -48,16 +48,23 @@ impl Client {
 		&self,
 		currencies: Vec<String>,
 	) -> Result<Vec<quotes::Currency>> {
-		let currencies = self.get_currencies_ids(&currencies)?;
+		let currency_mapping: HashMap<String, String> = currencies
+			.clone()
+			.into_iter()
+			.zip(self.get_currencies_ids(&currencies)?.into_iter())
+			.collect();
+
+		let mut currency_ids: Vec<_> = currency_mapping.values().cloned().collect();
+		currency_ids.sort();
 
-		let response = self.client.quotes_latest_by_id(currencies.join(",")).await?;
+		let response = self.client.quotes_latest_by_id(currency_ids.join(",")).await?;
 
 		currencies
 			.into_iter()
 			.map(|currency| {
 				response
 					.data
-					.get(&currency)
+					.get(currency_mapping.get(&currency).unwrap())
 					.and_then(|currency| currency.quote.get(currencies::USD.code).cloned())
 					.ok_or_else(|| Error::NotFound(currency.to_owned()))
 			})