Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B-1216] Add LORDS currency support #36

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

AnthonyBuisset
Copy link

No description provided.

Copy link

github-actions bot commented Dec 6, 2023

The following files have changed. It may have impacted environment variables:

  • api/app.yaml

Confirm that you have:

  • updated environment variables in staging
  • updated environment variables in production
  • done any required change in Heroku (new dynos, new apps, etc.)

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (2880639) 35.24% compared to head (d87d346) 35.21%.
Report is 1 commits behind head on main.

Files Patch % Lines
...i/src/presentation/http/routes/payment/receipts.rs 0.00% 6 Missing ⚠️
...mmon/infrastructure/src/database/enums/currency.rs 0.00% 3 Missing ⚠️
common/testing/src/context/coinmarketcap.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   35.24%   35.21%   -0.03%     
==========================================
  Files         391      391              
  Lines       11985    11995      +10     
==========================================
  Hits         4224     4224              
- Misses       7761     7771      +10     
Flag Coverage Δ
unittest 35.21% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PierreOucif PierreOucif merged commit 99920fe into main Dec 6, 2023
8 of 9 checks passed
@PierreOucif PierreOucif deleted the b-1216-add-lords-currency-in-rust-api branch December 6, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants